Use typeof() to detect data type #95

krlmlr · 2016-02-09T08:42:03Z

instead of class().

From https://github.com/krlmlr/bigrquery/commit/50a1ff03afefa86dc7f7e4ef0bb0b8de294e5c81#commitcomment-15959160:

this will give better default behaviour for base vectors with classes that we don't know how to deal with otherwise.

instead of class().

hadley · 2016-02-10T21:32:12Z

R/upload.r

-    POSIXct = "TIMESTAMP",
-    stop("Unknown class ", paste0(class(x), collapse = "/"))
+  if (is.factor(x)) return("STRING")
+  if (inherits(x, "POSIXct")) return("TIMESTAMP")


This should test for "POSIXt"

Use typeof() to detect data type

Kirill Müller added 2 commits February 9, 2016 09:51

use typeof() to detect data type

226c2a9

instead of class().

Merge branch 'master' into feature/upload-typeof

556fa94

hadley reviewed Feb 10, 2016
View reviewed changes

use POSIXt for checking time types

c9d3645

hadley added a commit that referenced this pull request Feb 10, 2016

Merge pull request #95 from krlmlr/feature/upload-typeof

b4f438b

Use typeof() to detect data type

hadley merged commit b4f438b into r-dbi:master Feb 10, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use typeof() to detect data type #95

Use typeof() to detect data type #95

krlmlr commented Feb 9, 2016

hadley Feb 10, 2016

Use typeof() to detect data type #95

Use typeof() to detect data type #95

Conversation

krlmlr commented Feb 9, 2016

hadley Feb 10, 2016

Choose a reason for hiding this comment